WIP: Deployment attempt to AWS #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpscholten
reviewed
Nov 24, 2023
| migrations = ./Application/Migration; | ||
| schema = ./Application/Schema.sql; | ||
| fixtures = ./Application/Fixtures.sql; | ||
| sessionSecret = "M$cmzMCEx7xfL-5_q6%9cpve_0BAd5BbDaOtzhv7"; |
There was a problem hiding this comment.
The session secret should not be public, anyone with knowledge of the sessionSecret can write to the session cookie (e.g. override the logged in user or something else)
There was a problem hiding this comment.
That's right, this is a dummy PR that we will throw away, we do not intend to deploy this project. Also we won't use this secret elsewhere.
There was a problem hiding this comment.
@mpscholten Yeah, we've done it so you'd have access to the code 😄
We can also invite you to the dummy AWS instance - so you'd have full visibility of the problem.
|
Closed in favor of #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.